sysbuild: Default to swap using offset for MCUboot #93310
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This swapping method is more efficient than swap using move and has been available for some time, remove experimental flag and set it as the default except for stm32 devices which have partition alignment for swap using move Signed-off-by: Jamie McCrae <[email protected]>
|
pdgendt
reviewed
Jul 18, 2025
| @@ -45,7 +47,6 @@ config MCUBOOT_MODE_SINGLE_APP | |||
|
|
|||
| config MCUBOOT_MODE_SWAP_USING_OFFSET | |||
| bool "Swap using offset" | |||
| select EXPERIMENTAL | |||
| help | |||
There was a problem hiding this comment.
Funnily this description isn't really helpful IMO. I would have expected to learn about the difference between USING_MOVE vs USING_OFFSET from the help texts. But they appear to be identical.
There was a problem hiding this comment.
The description is in MCUboot: https://github.com/mcu-tools/mcuboot/blob/main/boot/zephyr/Kconfig#L481
There was a problem hiding this comment.
Sure, but it wouldn't hurt refer to it.
butok
approved these changes
Jul 18, 2025
henrikbrixandersen
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This swapping method is more efficient than swap using move and has been available for some time, remove experimental flag and set it as the default except for stm32 devices which have partition alignment for swap using move
FYI @erwango